allanaaa
commented
1 week ago -
Clicking on the "View all results" doesn't re-zoom the map to contain them, so that's a bit disorienting.
-
When you click, the text bars/button appear above and below the map, which means the map moves around on the page. We probably don't want to have a container grow or shrink in height when clicked. Maybe we can overlay the results info on the map in some way - or just reserve empty space for it somewhere.
I wonder if a "Map by groups" block should have some kind of title or text to indicate what's going on inside. So perhaps if there is always a text box indicating the selection of the "Group by" dropdown ("Items grouped by resource class / [property name] / etc" which then changes to the selected grouping on click would solve both problems. I like that you have it styled consistenly with a search result indicator, and I'd keep that if we can.
jimsafley
kimisgold
The
map-by-groups-block-plus-optimizationbranch introduces the "Map by groups" block for site pages. With this block, users can view groups of items on a map, and click on an individual group to view its component items (or, more accurately, its items' features). For example, we have a map that contains item sets. When clicked, an item set will expand to all items that are assigned to that item set.The module calculates a group's location on the map by collecting all its component features and generating what's called a convex hull around the outermost points. Administrators have the option to render a groups as a polygon (i.e. the convex hull) or as a central point of the polygon.
In addition to testing the new "Map by groups" block, you'll need to test the existing "Map by attachment" and "Map by query" blocks, including their timeline and WMS overlay features. This is due to major refactoring of the block code that I needed to do. After checking out the
map-by-groups-blockbranch you should see no difference in your existing Mapping blocks: same configuration, same behavior, and same output.To test this block, add the new "Map by groups" block to a page. You should see the normal "Default view" and "WMS overlays" sections and a new "Groups" section that contains the following fields:
Once a user selects a "Group by" the form should expand with fields. The fields that appear depend on what the user selects.
Item sets
Resource classes
Property values (is exactly)
Property values (contains)
Property values (is item with ID)
Properties (has any value)
After you have configured a "Map by groups" block (you should test every combination), view the public page. You should see a map with groups rendered as polygons or points, depending on how you configured it. Verify that each group represents every item in the group. Click on a group and verify that the popup content makes sense for the group. Click on the "Show all" button and verify that the map reloads, rendering all component features. This map should behave identically to the existing "Map by" blocks. Click on the "Return to groups" button and verify that the map reloads, rendering the original groups.