search

omeka-s-themes / centerrow

GNU General Public License v3.0
2 stars 14 forks source link

Long subnavigation bumps content down when first block is item showcase #18

Closed patrickmj closed 7 years ago

patrickmj commented 7 years ago

Haven't explored yet whether a similar thing happens in other contexts, but when I have a first block that's item showcase, and a long list of subnavigation pages, the navigation bumps the images for the showcase down, creating a big white space.

centerrownav

patrickmj commented 7 years ago

To clarify, the first block besides the title block. Same with other block types

kimisgold commented 7 years ago

@patrickmj Can you pull and confirm https://github.com/omeka-s-themes/centerrow/commit/331ae4962835b48aac8fadd220620f7178941b31 fixes this issue? This uses a flexbox solution, so you might also want to check other pages that either don't feature the subnavigation or include special module content.

patrickmj commented 7 years ago

No dice. The title moved a bit, but the whitespace remains. I'm not sure if this is new or not, but I also noticed that my item with metadata block below the showcase block doesn't work with the prev-next navigation.

centerrownewtop

centerrownewfoot

kimisgold commented 7 years ago

Sorry, I forgot to mention you should pull from core, as there's now a wrapper that helps lay out the site blocks. (https://github.com/omeka/omeka-s/commit/7307beed207ccdae02addc614b8b6f882b77fd88)

patrickmj commented 7 years ago

Ah! Indeed, that looks like it fixes it to me. Haven't bopped around different page and block types, nor modules adding stuff yet. but the immediate issue seems solved.