search

omeka / plugin-Geolocation

Allows administrative users to save geolocation data for an individual item. The plugin generates a Google map containing items with geolocation data and a web page for displaying the map.
http://omeka.org/codex/Plugins/Geolocation
12 stars 20 forks source link

Retest search and display #7

Closed patrickmj closed 10 years ago

patrickmj commented 11 years ago

@sheilabrennan Confirm searching on items works

Confirm maps display on public and admin pages

sheilabrennan commented 11 years ago

Issues you know from me: public and admin items/map show no pins, but recognize items pinned to map.

Also tried searching on the map: items are found by search but still not displayed on admin map.

Patrick, if you are having trouble replicating this error with an install on a web server that is not omekadev, please let me know. Might need to get James to also test on his dreamhost site, or I can do that too.

patrickmj commented 11 years ago

Should be fixed in the latest master @sharonmleon @sheilabrennan @leeannghajar @jhalabuk , please pull the latest to test that the fix I made is covered across browsers (pretty confident it is, but ya never know!)

Should expect that the map of everything now only displays items that have location data. Think that's expected behavior, but worth checking.

leeannghajar commented 11 years ago

Initial test in latest Firefox.

Admin: search for items using keyword or field or tag not showing any results Public View: Browse items on the Map showing no results Search gives results; results do not display on map

jhalabuk commented 11 years ago

Firefox with a Dreamhost install: Geo'd items are visible from both the admin and public side. Makes no difference whether I search by tag, keyword, or if I browse. All seems to be working as expected for my install.

Screen Shot 2013-03-13 at 12 04 33 PM

Screen Shot 2013-03-13 at 12 05 06 PM

sheilabrennan commented 11 years ago

One thing I noticed looking at the items/map browse page on my phone is that the map doesn't resize/adjust, but it does comply with the resizing on items/show. Can that be tweaked, @kimisgold? I've looked at my site in Thanks, Roy and Season in Chrome and Safari for ios.

gsbodine commented 11 years ago

Perhaps this is just my set-up, but after some updates of this plugin lately, I got reports that our map no longer limits the items per page. The paging navigation shows up, but the map shows all the items in the list (after struggling to load all 4500 items with locations :) ). I have made a few changes, but as far as I can tell after diffing, the source is up to date with master in all areas that seem to matter. Has anyone tested with a fairly large set of location items or seen anything similar to this?

sheilabrennan commented 11 years ago

Have you tried limiting the number of items that appear on the map through configuring the plugin in the admin settings? Try for something under 50 and see if that number is saved.

gsbodine commented 11 years ago

Yes, and it appeared to do no good. I changed the settings in the admin config, and then even the max listed in the code, all to no avail. I wasn't sure if anyone had enough geolocated items to test the limiting. Thanks for the ideas.

leeannghajar commented 11 years ago

Have tested configuring plugin changing on two different Omeka installs on dev: (The number of locations displayed per page when browsing the map. (Maximum is 50).

Numeric filter doesn't work. All geolocated items continue to show up on the map.

patrickmj commented 11 years ago

Problem of maximum items for map browse should be fixed in https://github.com/omeka/plugin-Geolocation/commit/d2f1ac0f604dfd86c20a485283ddf20336be798a

@leeannghajar can you confirm on the latest master? thanks!

gsbodine commented 11 years ago

I can confirm on my install after update from master. Thanks Patrick!

sheilabrennan commented 11 years ago

Awesome, so can I. Thanks!

leeannghajar commented 11 years ago

Eureka. Thanks, Patrick.