omeryusufyagci / fast-music-remover

A C++ based, lightweight music and noise remover for YouTube and other internet media, using DeepFilterNet for audio enhancement.
MIT License
200 stars 21 forks source link

Feature: Add a CLI for `MediaProcessor` #10

Open omeryusufyagci opened 2 months ago

omeryusufyagci commented 2 months ago

Currently testing and using the MediaProcessor is tied to the front end. This is not necessarily required, and it would allow greater flexibility if MediaProcessor could be used via a CLI. Since it's used by providing a file path, this should be a simple operation.

Objectives:

malikrohail commented 2 months ago

can i fix this

omeryusufyagci commented 2 months ago

Hi @malikrohail, thank you for offering to help on this, much appreciated! I've assigned the issue to you, and you can find below more concrete details on how we could continue with the implementation:

Name: Let's call it fmremover for simplicity.

Usage: Our initial goal is to have basic CLI functionality, but eventually, it'll be very useful to be able to use the CLI for doing statistics and testing. With this in mind, I have the following usage in mind:

fmremover <subcommand> [options]

For now, the subcommand can default to process if no subcommand is provided. You can implement this without any additional options to start with, and we can add more features later.

Language: Using C++ for the CLI will keep everything consistent with our current codebase, which will be advantageous for future extensions. That said, I'm open to suggestions if you have another language in mind that you think would work well.

Location: Please add the CLI code to a new directory named fmremover-cli/ under the project root.

Scope: The initial goal is to achieve a simple and working implementation, so the CLI should:

Does this sound good to you? Thanks again, and I look forward to working with you!

Master9090rgb commented 1 month ago

I know this issue has been assinged to someone but still i would like to work on this if it has not been fixed yet I have good experience working with c++ but do not have experience in open source contribution if you would help me understand what all operations you want with the CLI. I would try to make one Thank You

omeryusufyagci commented 1 month ago

Hi @Master9090rgb, thanks for your interest! I'm not sure if @malikrohail has an update? Let's try to hear back from him, but we can always share the work as well.

Also, you can take a look at the MediaProcessor if you're interested in the C++ side of the project.

malikrohail commented 1 month ago

I’m almost finished, will push changes by the end of today

omeryusufyagci commented 1 month ago

Hi @malikrohail, any news on this? Thanks for your feedback

omeryusufyagci commented 1 month ago

Hi @malikrohail, do you have any news on this? When can we expect to see a first version? Thanks!