search

omeryusufyagci / fast-music-remover

A C++ based, lightweight music and noise remover for YouTube and other internet media, using DeepFilterNet for audio enhancement.
MIT License
199 stars 21 forks source link

Add validation and error handling for YouTube URL in Fast Music Remover #38

Closed wenayy closed 1 month ago

wenayy commented 1 month ago

Details of Changes:

Added validation to ensure that only valid YouTube URLs can be submitted. Implemented detailed error handling for failed requests and displayed error messages to users. Included a loading spinner that is shown while the video is being processed. The video player is now hidden by default and only displayed once a valid video is ready. Added accessibility improvements with aria-label to make the form more usable for screen readers.

omeryusufyagci commented 1 month ago

Thanks for your interest in this project. This PR has peculiarly high similarities with #17 -an almost one-to-one match in fact. Have you seen my comment in #16 about these suggested changes? As your PR is almost the same as #17, please take a moment to go over the feedback given there.

We definitely need frontend improvements, but this PR doesn't satisfy the requirements outlined in #16.

I am happy to review it again once you address the mentioned comments, until then I am closing this as duplicate.