search

omgnetwork / optimism

Monorepo implementing the Optimistic Ethereum protocol
https://optimism.io
MIT License
16 stars 6 forks source link

Gateway Improvement - My Deposit Only Filter Issue (Earn page) #524

Closed MitchellUnknown closed 3 years ago

MitchellUnknown commented 3 years ago

When you switch on the my deposits only filter you will get every token that is providing liquidity, instead of showing you only the tokens, in which you are providing liquidity

Gateway - Earn My Deposits Only Filter Issue .

CAPtheorem commented 3 years ago

The 'My Deposits Only' refers to all tokens in your wallet, not to the pools in which you are providing liquidity. We could add another checkbox 'My stakes Only' which would show only the pools for which you are proving liquidity. Would that be useful?

MitchellUnknown commented 3 years ago

The 'My Deposits Only' refers to all tokens in your wallet, not to the pools in which you are providing liquidity. We could add another checkbox 'My stakes Only' which would show only the pools for which you are proving liquidity. Would that be useful?

It would be nice to only see your staked coins, but at this point i don’t think thats a real priority compared to the workload you guys are having at the moment. So maybe put this on the bottom on the to do list. I think the text ‘My Deposits Only’ for now is a bit confusing. It suggest that the filter will only show my staked coins, at least that was my first thought when i pressed the checkmark.

ghost commented 3 years ago

Maybe it should be "Owned Assets Only" as well as a "Staked Assets Only".

Also, currently when I clicked on "My Deposits Only", it shows all assets that have liquidity in them. I currently don't have any assets bridged so it might be different once I do, but it should be none.

image

MitchellUnknown commented 3 years ago

I am always the kind of guy that likes things super simple, and intuitive. My first thought when entering the earn page and I see a long list of coins, where are the buttons/filters that will lead to my staked coins or my outstanding earnings? I dont know if thats possible to implement, but this is me just thinking out loud as a user.

[ x ] Show my staking OR [ x ] Hide zero balances [ x ] Show my earnings

EpicChicken commented 3 years ago

I'm also seeing all tokens with liquidity whether I own any or not. I'm using a new MEW wallet that has only ever had ETH and OMG on it. I have both staked on L2. When I check the 'My Deposits Only' box I still see Tether, DAI, USD, and SUSHI even though I've never had any of those in my wallet.

CAPtheorem commented 3 years ago

"Show my stakes" filtering will be added today

CAPtheorem commented 3 years ago

Fixed in https://github.com/omgnetwork/optimism/pull/552