omise / omise-magento

Omise Magento Plugin
https://docs.opn.ooo/magento-plugin
MIT License
34 stars 19 forks source link

[ENGA3-677] : Replace card-form with pay.js embedded form #410

Closed ajzkk closed 1 year ago

ajzkk commented 1 year ago

1. Objective

Replace card-form with pay.js embedded form

ENGA3-677

2. Description of change

3. Quality assurance

Tested locally

4. Impact of the change

N/A

5. Priority of change

N/A

aashishgurung commented 1 year ago

It is convention to add extra empty line at the end of the file. Could you please add it for consistency?

ajzkk commented 1 year ago

It is convention to add extra empty line at the end of the file. Could you please add it for consistency?

@aashishgurung I believe I added for all files, which file did I miss to add?

aashishgurung commented 1 year ago

My bad. Ignore my feedback. I was looking into Github files. I forgot Github will show automatically if the newline is missing at the end of file.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication