search

omni / tokenbridge-contracts

Smart contracts for TokenBridge
http://docs.tokenbridge.net
GNU General Public License v3.0
230 stars 228 forks source link

transfer and transferFrom behaves differently when bridge contract is receiver #216

Closed akolotov closed 5 years ago

akolotov commented 5 years ago

The method transfer in ERC677BridgeToken has been extended to handle properly the case when it was used to transfer tokens to the bridge contract instead of calling transferAndCall.

https://github.com/poanetwork/poa-bridge-contracts/blob/e32ef6e1f2cc78a07fd96a321b426a64a2f87132/contracts/ERC677BridgeToken.sol#L57-L68

But the method transferFrom remains unchanged. So, behavior will be inconsistent for the similar functionality.

akolotov commented 5 years ago

Included in TokenBridge contracts 2.3.3