Add bridge contracts as git submodule

omni / tokenbridge

Mono repository of Token Bridge (Oracle, Deployment, Monitor). TokenBridge is an interoperability solution between EVM-based networks for assets/data cross chain transfers

http://docs.tokenbridge.net

GNU General Public License v3.0

278 stars 212 forks source link

Add bridge contracts as git submodule #33

Closed patitonar closed 5 years ago

patitonar commented 6 years ago

Add poa-bridge-contracts (branch refactor_v1) repository as a git submodule and use compiled contracts instead of contracts on abis directory

rzadp commented 5 years ago

Is it not a duplicate of #21 ? Also I cannot seem to find refactor_v1 in poa-bridge-contracts. Should we not use 2.3.0-rc0 tag?

akolotov commented 5 years ago

Correct. I specified in #21 a list of work that needs to be done there as per the approach you are suggesting to follow: small set of changes for one issue.

akolotov commented 5 years ago

Let's consider this issue to introduce compilation of the contracts in the process of installing dependencies.

[ ] use ABIs of installed contracts in the oracle instead of pre-compiled ABIs.
[ ] use ABIs of installed contracts in the UI instead of pre-compiled ABIs.
[ ] use ABIs of installed contracts in the monitor instead of pre-compiled ABIs.

The most actual version of contracts should be used at the moment when this issue is assigned for implementation.

rzadp commented 5 years ago

This was done in #21