omnivore-app / omnivore

Omnivore is a complete, open source read-it-later solution for people who like reading.
https://omnivore.app
GNU Affero General Public License v3.0
13.93k stars 987 forks source link

Highlight with Apple Pen #2520

Open delafthi opened 1 year ago

delafthi commented 1 year ago

Acknowledgment

First of all, many thanks for this great app and your effort maintaining and evolving it.

Problem

In iBooks on the iPad I use the Apple pen a lot to directly highlight passages in the text, without having to highlight the text through the selection menu. Sadly, in Omnivore the pen does only replace my finger and does not provide this extra feature. Below a screen recording from me highlighting with my pen in iBooks.

https://github.com/omnivore-app/omnivore/assets/50531499/412b395e-6339-44b2-ab22-0d7e771c67ec

Request

Implementing the same feature in Omnivore would be very convenient, especially on a tablet with a pen.

jacksonh commented 1 year ago

Thanks, i know i tested once with a pen i borrowed from someone in the past and it worked.

Can I ask, its not working for you in articles, or PDFs, or both?

jacksonh commented 1 year ago

Oh actually i understand what you mean. Can you try opening the reader setting (where you set the Font and margins), and go to Advanced settings, and choose "Auto Highlight Mode" and see if that gives the effect you'd like?

delafthi commented 1 year ago

Thanks, for your swift response. I didn't even know these settings existed. The result is acceptable.

I think the main difference between the "Auto Highlight Mode" and highlighting in iBooks, is that in iBooks, the pen is detected as a different input device than your finger. In Omnivore, I scroll per default with the pen and to highlight I have to wait for a moment to go into selection mode (equal to highlighting with your finger). In iBooks, I cannot scroll with the pen, but the text is instantly highlighted (even without the text selection overlay, but that's a detail).

jacksonh commented 1 year ago

Ah very interesting, thanks. so scroll with your finger, and then highlight with the pen. I'll try to find one to test with!