search

omoponfhir / omoponfhir-stu3-server

OMOPonFHIR STU3 Server
Apache License 2.0
1 stars 3 forks source link

Schema Mutation #1

Open psbrandt opened 4 years ago

psbrandt commented 4 years ago

I have a question regarding the following Hibernate configuration option:

https://github.com/omoponfhir/omoponfhir-stu3-server/blob/c2ad29b42cd5d872535e34b80f56f9ac4719de1d/src/main/java/edu/gatech/chai/omoponfhir/config/FhirServerConfig.java#L79

Does this mean that using OMOP on FHIR could mutate the CDM schema? If so, is the intention to use this in production, or only in development? What preparation should a potential implementer do to prevent potentially undesirable mutations to their production CDM schema?

myungchoi commented 4 years ago

Our intention is to first use in development environment. There are other configurations that can be set to limit the access.

For the hibernate auto update, we set it to update as default because there were some needs for the server to update database schema. We can make this configurable if it can better support community's needs.

psbrandt commented 4 years ago

The main problem is that this setting may causes unexpected changes, and do so without notifying the user. I don't think people would like this situation in the production environment 🙂

To me it makes more sense to require manual (or automated with tools like Flyway or Liquibase) preparation of the schema. Hence my PR on the other repo.