Closed kahummer closed 4 years ago
Add links and info description to the legend The following specification should be used
"legendHyperlink": "google.com",
"legendDescription": "Provision of emergency humanitarian assistance to vulnerable populations",
"legendHyperlinkText": "Google doc Report",
The legendInfo won't require this since this is built at the layer level.
Instead of duplicating the description in the hyperlink, why can't we use the same info being used by the legend or vice versa? Or can one enter different descriptions for hyperlink and legend?
Add links and info description to the legend The following specification should be used
"legendHyperlink": "google.com", "legendDescription": "Provision of emergency humanitarian assistance to vulnerable populations", "legendHyperlinkText": "Google doc Report",
Where is this information added? in the hyperLink
object or?
@kelvin-muchiri Just figured we can use categories for the legend links. In that case, I'll be adding the link description only
Should be merged after https://github.com/onaio/gisida-react/pull/218 Fixes: https://github.com/onaio/irfsomalia/issues/889, https://github.com/onaio/irfsomalia/issues/894, https://github.com/onaio/irfsomalia/issues/897 This pr has changed the structure of our current menu to accommodate the hyperlinks. Some styling tweaks will be desired before we merge. The configuration had to change to target sub-sector/ sub-category level navigation based on the parent sector as a way of discerning in the event of duplicate
sub-sectors
. BRCis II is the parent sector. e.gMore docs on this https://github.com/onaio/gisida-react/blob/hyperlinks/docs/features/menu-legend-links.md The same specification will be used for the info Icon too. The legendInfo won't require this since this is built at the layer level. Screenshots of the current implementation
[x] Have consistent ui with previous implementations
[x] Legend info and Hyperlink
[x] Add tests
[x] Add menu links documentation
[x] Export unsets inner style
[x] Handle subsectors inside subsectors