onaio / gisida-react

React Dashboard library for Gisida.
http://gisida.onalabs.org/
Apache License 2.0
2 stars 2 forks source link

Hyperlinks #217

Closed kahummer closed 4 years ago

kahummer commented 4 years ago

Should be merged after https://github.com/onaio/gisida-react/pull/218 Fixes: https://github.com/onaio/irfsomalia/issues/889, https://github.com/onaio/irfsomalia/issues/894, https://github.com/onaio/irfsomalia/issues/897 This pr has changed the structure of our current menu to accommodate the hyperlinks. Some styling tweaks will be desired before we merge. The configuration had to change to target sub-sector/ sub-category level navigation based on the parent sector as a way of discerning in the event of duplicate sub-sectors. BRCis II is the parent sector. e.g

"hyperLink": {
      "Boundaries": {
        "link": "https://drive.google.com/file/d/1W93Tw3MOhjTEz8h2ycUbY-k6yZXf81Pi/view",
      },
      "BRCiS II Output Indicators": {
        "link": "https://drive.google.com/file/d/1W93Tw3MOhjTEz8h2ycUbY-k6yZXf81Pi/view",
      }

More docs on this https://github.com/onaio/gisida-react/blob/hyperlinks/docs/features/menu-legend-links.md The same specification will be used for the info Icon too. The legendInfo won't require this since this is built at the layer level. Screenshots of the current implementation Screenshot from 2020-08-03 20-09-02

kahummer commented 4 years ago

Add links and info description to the legend The following specification should be used

"legendHyperlink": "google.com",
"legendDescription": "Provision of emergency humanitarian assistance to vulnerable populations",
"legendHyperlinkText": "Google doc Report",

Screenshot from 2020-07-30 11-52-57

kelvin-muchiri commented 4 years ago

The legendInfo won't require this since this is built at the layer level.

Instead of duplicating the description in the hyperlink, why can't we use the same info being used by the legend or vice versa? Or can one enter different descriptions for hyperlink and legend?

kelvin-muchiri commented 4 years ago

Add links and info description to the legend The following specification should be used

"legendHyperlink": "google.com",
"legendDescription": "Provision of emergency humanitarian assistance to vulnerable populations",
"legendHyperlinkText": "Google doc Report",

Screenshot from 2020-07-30 11-52-57

Where is this information added? in the hyperLink object or?

kahummer commented 4 years ago

@kelvin-muchiri Just figured we can use categories for the legend links. In that case, I'll be adding the link description only