search

onaluf / fate

Flexible Angular Text Editor
MIT License
37 stars 14 forks source link

FateModule needs @angular/material/form-field #72

Closed Applicafroguy closed 3 years ago

Applicafroguy commented 4 years ago

This is the error when I import FateModule

/node_modules/fate-editor/fesm2015/fate-editor.js Module not found: Error: Can't resolve '@angular/material/form-field'

onaluf commented 4 years ago

I’ll try to reproduce this. You shouldn’t needed to use material if you don’t want to!

onaluf commented 4 years ago

:tada: This issue has been resolved in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

linusbrolin commented 4 years ago

@onaluf I'm still getting error even in 2.0.0 when compiling:

ERROR in node_modules/fate-editor/app/fate-material/fate-material.component.d.ts(3,37): error TS2307: Cannot find module '@angular/material/form-field'.

I'm using angular 7.2 and a clean default install of fate

onaluf commented 4 years ago

@linusbrolin did you import the FateMaterialModule? Because if you did you will need material dependencies. If you didn’t then it’s a bug.

onaluf commented 4 years ago

Or maybe it’s because it’s angular 7... fate-editor 2.0 depends on Angular 8+

linusbrolin commented 4 years ago

I did not import the FateMaterialModule. Unfortunately I cannot test with Angular 8 at the moment, because it requires a later Node version and I have a very big work project on Angular 7 that cannot be upgraded to 8 or 9 just yet. :/

So for now I guess I'm gonna have to downgrade to fate 1.9.3 and install material.

onaluf commented 4 years ago

I’ll try to reproduce the issue and see if I can fix it for angular 7. There should be a way.

On Fri, 3 Apr 2020 at 21:38, linusbrolin notifications@github.com wrote:

I did not import the FateMaterialModule. Unfortunately I cannot test with Angular 8 at the moment, because it requires a later Node version and I have a very big work project on Angular 7 that cannot be upgraded to 8 or 9 just yet. :/

So for now I guess I'm gonna have to downgrade to fate 1.9.3 and install material.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/onaluf/fate/issues/72#issuecomment-608622709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACILZ5MZKUK4NBPG7Y6CLDRKY3LRANCNFSM4KUOXZRQ .

onaluf commented 4 years ago

So @linusbrolin I've tested and indeed it's not working, not for 7.0 but nor for other versions... not sure why I thought it did. I'll work some more on this.

linusbrolin commented 4 years ago

Alright, thank you.

onaluf commented 3 years ago

I think this issue has been fixed in the last release, please check if it work for you and if it doesn't, comment here and I'll reopen this issue!