oncoray / mirp

Medical Image Radiomics Processor
https://oncoray.github.io/mirp/
European Union Public License 1.2
53 stars 14 forks source link

General comments, text and documentation+ curiosity #69

Closed theanega closed 7 months ago

theanega commented 8 months ago
  1. General - great job and thanks! First of all, huge congrats for the quality of the submitted project and for advancing radiomics research. I mean this not only with the MIRP package but also IBSI, IBSI2, etc. I always enjoy your papers. As a potential future user, I particularly appreciate the implementation of the fixed_bin_size_puradiomics feature. By extending MIRP to support non-IBSI compliant implementations, you are enabling other users to use MIRP to validate a wider range of radiomics results. This was a necessary and valuable addition to the field.

  2. Text - minor correction: Second paragraph of the Statement of need has 4 in-text citations that do not follow the same format as the others.

  3. Documentation - good to go for now but some areas could benefit from extended content/additional clarifications and examples in the future...

Curiosity/question:

alexzwanenburg commented 7 months ago

Thanks! I have started working on installation and quick-start sections of the long-form documentation.

Regarding your question: MIRP currently does not allow for computing radiomics feature maps. I agree it would be interesting. Creating an implementation that performs well will likely take some time and may require translating parts of the code to C or Cython. It is not something I plan to do anytime soon.

Matthew-Jennings commented 7 months ago

@theanega and @alexzwanenburg, just on point 2:

I believe that the four citations @theanega refers to are narrative in-text citations whereas the others are parenthetical. It is common to include both formats in a paper. See this APA Style and Grammar Guidelines webpage. I don't think any correction is needed here.