search

one-dark / jetbrains-one-dark-theme

One Dark theme for JetBrains.
https://plugins.jetbrains.com/plugin/11938-one-dark-theme
ISC License
589 stars 67 forks source link

One Dark Vivid Italic displays wrong styling in RustRover #325

Closed viktaur closed 9 months ago

viktaur commented 11 months ago

Describe the bug

One Dark Vivid Italic does not apply the expected styling to the IDE. Instead, it makes the background darker, keywords orange and non-italic, and enum variants italic, among others. I have tried reinstalling the pluging and restarting the IDE and my device, but the bug is persistent. The other One Dark themes seem to work fine.

To Reproduce

  1. Open Rust Rover with One Dark Theme installed
  2. Go to Settings > Theme
  3. Select One Dark Vivid Italic

Expected Behavior

The expected styling should be somewhere between One Dark Italic and One Dark Vivid.

Environment

RustRover 2023.3 EAP Build #RR-233.11799.306 Runtime version: 17.0.9+7-b1087.7 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. macOS 13.4.1 GC: G1 Young Generation, G1 Old Generation Memory: 2048M Cores: 10 Metal Rendering is ON Registry: ide.experimental.ui=true Non-Bundled Plugins: com.markskelton.one-dark-theme (5.9.0)

Screenshots

image
viktaur commented 11 months ago

This turned out to be related to #313 and solved by https://github.com/one-dark/jetbrains-one-dark-theme/issues/313#issuecomment-1740902198. However, I am still not sure why this only happened with One Dark Vivid Italic.