search

onecodex / finch-rs

A genomic minhashing implementation in Rust
https://www.onecodex.com
MIT License
93 stars 8 forks source link

Linux executable #9

Closed HadrienG closed 6 years ago

HadrienG commented 6 years ago

Hi!

I'm reviewing your Joss submission and I was having troubles with the linux executable. It appears that the .gz file available to download is actually a tar archive.

Instinctively I did

wget https://github.com/onecodex/finch-rs/releases/download/v0.1.4/finch-linux64-v0.1.4.gz
gzip -d finch-linux64-v0.1.4.gz
chmod +x finch-linux64-v0.1.4 
./finch-linux64-v0.1.4 
# -bash: ./finch-linux64-v0.1.4: cannot execute binary file

And indeed

file finch-linux64-v0.1.4
# finch-linux64-v0.1.4: POSIX tar archive (GNU)

I think it'd be less confusing for users to name the file finch-linux64-v0.1.4.tar.gz

Otherwise the software executes fine after unpacking! I may come back to you with others issues or suggestions later during the day 😃

Best, Hadrien

boydgreenfield commented 6 years ago

@HadrienG Thanks for catching that sloppy packaging! Just updated the binary to have the right extension.