issues
search
onehashai
/
onehash-connect
Apache License 2.0
1
stars
0
forks
source link
Develop
#18
Closed
rishabh-onehashai
closed
10 months ago
rishabh-onehashai
commented
10 months ago
Fixes:
Screenshots and screen captures:
Self-review checklist
- [ ] [Self-reviewed](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code) the changes for clarity and maintainability (variable names, code reuse, readability, etc.). Communicate decisions, questions, and potential concerns. - [ ] Explains differences from previous plans (e.g., issue description). - [ ] Highlights technical choices and bugs encountered. - [ ] Calls out remaining decisions and concerns. - [ ] Automated tests verify logic where appropriate. Individual commits are ready for review (see [commit discipline](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html)). - [ ] Each commit is a coherent idea. - [ ] Commit message(s) explain reasoning and motivation for changes. Completed manual review and testing of the following: - [ ] Visual appearance of the changes. - [ ] Responsiveness and internationalization. - [ ] Strings and tooltips. - [ ] End-to-end functionality of buttons, interactions and flows. - [ ] Corner cases, error conditions, and easily imagined bugs.
Fixes:
Screenshots and screen captures:
Self-review checklist
- [ ] [Self-reviewed](https://zulip.readthedocs.io/en/latest/contributing/code-reviewing.html#how-to-review-code) the changes for clarity and maintainability (variable names, code reuse, readability, etc.). Communicate decisions, questions, and potential concerns. - [ ] Explains differences from previous plans (e.g., issue description). - [ ] Highlights technical choices and bugs encountered. - [ ] Calls out remaining decisions and concerns. - [ ] Automated tests verify logic where appropriate. Individual commits are ready for review (see [commit discipline](https://zulip.readthedocs.io/en/latest/contributing/commit-discipline.html)). - [ ] Each commit is a coherent idea. - [ ] Commit message(s) explain reasoning and motivation for changes. Completed manual review and testing of the following: - [ ] Visual appearance of the changes. - [ ] Responsiveness and internationalization. - [ ] Strings and tooltips. - [ ] End-to-end functionality of buttons, interactions and flows. - [ ] Corner cases, error conditions, and easily imagined bugs.