onehouseinc / LakeView

Monitoring and insights on your data lakehouse tables
Apache License 2.0
15 stars 3 forks source link

Improve 401 error message #84

Closed yongkyunlee closed 1 month ago

yongkyunlee commented 1 month ago

401 error message is usually due to invalid or expired Onehouse API token. Improve error message to help users debug the issue.

Manually tested by specifying a wrong api secret and ran the jar locally. Then I see below logs

17:20:18.955 [metadata-extractor-2] INFO  c.o.m.TableDiscoveryService - Discovering tables in s3://acme-lake/acme/acme_default/1clickstream_event/v1/
17:20:19.001 [metadata-extractor-1] INFO  c.o.m.TableMetadataUploaderService - Uploading metadata of following tables: [Table(absoluteTableUri=s3://acme-lake/acme/acme_default/1clickstream_event/v1/, databaseName=daniel-database, lakeName=daniel-lake, tableId=null)]
17:20:19.003 [metadata-extractor-1] INFO  c.o.m.TableMetadataUploaderService - Fetching checkpoint for tables: [Table(absoluteTableUri=s3://acme-lake/acme/acme_default/1clickstream_event/v1/, databaseName=daniel-database, lakeName=daniel-lake, tableId=11a9bb56-9002-346f-8dc3-01e75fddb382)]
17:20:19.139 [metadata-extractor-1] ERROR c.o.m.TableMetadataUploaderService - Error encountered when fetching checkpoint, skipping table processing. status code: 401. message: Confirm that your API token is valid and has not expired.
nimahajan commented 1 month ago

Task linked: ENG-11575 Add "expired token" note in API 401 errors

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud