Remove attachments enabling flag

SupunS commented 1 month ago

Description

Attachments are enabled on all networks now. So the flag is no longer needed.

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work
[x] Code follows the standards mentioned here
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

github-actions[bot] commented 1 month ago

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit 85f46f73c95ef510facf48e28470b2eada9fc519 The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used. Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.20%. Comparing base (d90d449) to head (0e1b932). Report is 68 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #3642 +/- ## ========================================== - Coverage 80.53% 80.20% -0.33% ========================================== Files 432 411 -21 Lines 97964 95543 -2421 ========================================== - Hits 78891 76629 -2262 + Misses 16321 16228 -93 + Partials 2752 2686 -66 ``` | [Flag](https://app.codecov.io/gh/onflow/cadence/pull/3642/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/cadence/pull/3642/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `80.20% <ø> (-0.33%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SupunS commented 1 month ago

The backward compatibility checker fails due to missing 5f195aa4322e5dbb.EVMHelper:71(5:2):*sema.AttachmentsNotEnabledError error, because the analyzer tool didn't have the attachments enabled flag on. So this is expected.

Interestingly, seems EVMHelper is the only one using attachments at the moment 😄

onflow / cadence