onflow / cadence

Cadence, the resource-oriented smart contract programming language 🏃‍♂️
https://cadence-lang.org
Apache License 2.0
534 stars 138 forks source link

Refactor and update struct stringer tests #3661

Closed SupunS closed 3 weeks ago

SupunS commented 3 weeks ago

Blocker for https://github.com/onflow/cadence/pull/3660

Description

Actual change is in https://github.com/onflow/cadence/commit/247a13d3eabdbe98af126ef762fbf527caeca4a7

Also synced with master again.


github-actions[bot] commented 3 weeks ago

Cadence Benchstat comparison

This branch with compared with the base branch onflow:feature/string-templates commit 4f9e343b48a518487f8e273b49c92855cfc537d1 The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used. Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

turbolent commented 3 weeks ago

Sorry for the extra hassle getting this in!

SupunS commented 3 weeks ago

no problem! It's just happened to be dependent on the order of PRs merged. I didn't realize it either.