Closed illia-malachyn closed 1 month ago
The recent updates enhance the observability and monitoring capabilities of the codebase by integrating metrics collection into various components. Key functions and structures are modified to include a metrics.Collector
, allowing for more granular tracking of events and errors, particularly in trace download processes. This improves both performance insights and error handling across the system.
Files | Change Summary |
---|---|
bootstrap/.../bootstrap.go |
Added collector parameter to Start and startIngestion functions to facilitate metrics collection. |
metrics/.../collector.go |
Introduced TraceDownloadFailed() method to Collector interface; added traceDownloadErrorCounter to DefaultCollector . |
metrics/.../noop_collector.go |
Added NewNoopCollector() constructor; introduced TraceDownloadFailed() method to NoopCollector . |
🐰 In fields of code, new metrics bloom,
A rabbit hops through the devs' busy room.
With collectors in hand, we measure the trace,
Each error logged with a smile on our face.
So here's to the changes, both bright and profound,
In the world of coding, joyfully bound! 🥕
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@sideninja let's merge it in
This covers "Trace download failures should be recorded'
Summary by CodeRabbit
New Features
NoopCollector
to improve its usability.Bug Fixes
Tests