search

onflow / flow-go

A fast, secure, and developer-friendly blockchain built to support the next generation of games, apps, and the digital assets that power them.
GNU Affero General Public License v3.0
533 stars 179 forks source link

Add support for building private dependencies in CI #6728

Closed sjonpaulbrown closed 1 week ago

sjonpaulbrown commented 1 week ago

PR Description: Add Support for Building Private Dependencies in CI

This PR introduces changes to support building private dependencies in the CI pipeline, specifically for private Cadence repositories.

Key Changes

  1. Update CI steps to load Cadence Deploy Key in CI:

    • Adds CI step to load the CADENCE_DEPLOY_KEY into the SSH agent for accessing private repositories.
    • Configures Git to use SSH for dependencies.
    • Dynamically sets SSH_AUTH_SOCK in the environment.
    • Warns if CADENCE_DEPLOY_KEY is not set, allowing the workflow to continue.

  2. Update GOPRIVATE Configuration:

    • Updates GOPRIVATE to github.com/onflow/* in both the GitHub Actions workflow and the Makefile to bypass the Go module proxy for private repositories.

Impact

These changes enable seamless fetching and building of private Cadence dependencies during CI, improving the reliability and security of the build process.

codecov-commenter commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.54%. Comparing base (4162017) to head (ea28672).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v0.37 #6728 +/- ## ========================================== - Coverage 41.55% 41.54% -0.01% ========================================== Files 2026 2026 Lines 181069 181069 ========================================== - Hits 75248 75231 -17 - Misses 99595 99613 +18 + Partials 6226 6225 -1 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-go/pull/6728/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-go/pull/6728/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `41.54% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: