search

onflow / flow-go

A fast, secure, and developer-friendly blockchain built to support the next generation of games, apps, and the digital assets that power them.
GNU Affero General Public License v3.0
533 stars 179 forks source link

Fix zero address issue on replay #6731

Closed bluesign closed 1 week ago

bluesign commented 1 week ago

When testate was deployed initially coinbase was 0x0000000000000000000000000000000000000000 address, then it switched to 0x0000000000000000000000030000000000000000

normally 0x0 should have exist ( not created ) but it is being created later on on testnet, this is a little hack to keep gasUsage consistent when replaying blocks.

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.22%. Comparing base (6a254ed) to head (a257c79). Report is 318 commits behind head on master.

Files with missing lines Patch % Lines
fvm/evm/offchain/sync/replay.go 0.00% 5 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6731 +/- ## ========================================== + Coverage 41.14% 41.22% +0.07% ========================================== Files 2031 2054 +23 Lines 179571 182370 +2799 ========================================== + Hits 73886 75183 +1297 - Misses 99475 100885 +1410 - Partials 6210 6302 +92 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-go/pull/6731/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-go/pull/6731/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `41.22% <0.00%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

janezpodhostnik commented 1 week ago

then it switched to 0x0000000000000000000000030000000000000000

@bluesign do we know why? was it an HCU?

edit: Never mind I saw https://github.com/onflow/flow-go/pull/6733

bluesign commented 1 week ago

Oh I forgot to close this