search

onflow / flow-go

A fast, secure, and developer-friendly blockchain built to support the next generation of games, apps, and the digital assets that power them.
GNU Affero General Public License v3.0
533 stars 179 forks source link

[EFM] Refactored encoding and decoding of DKG data during bootstrapping #6745

Closed durkmurder closed 4 days ago

durkmurder commented 1 week ago

https://github.com/onflow/flow-go/issues/6726

Context

Refactored encoding structures to correctly represent available data, previously it was missing information about participants. Also grouped it by participant to avoid relying on indexing for 3 structures, now instead of 3 different slices we have 1.

codecov-commenter commented 1 week ago

Codecov Report

Attention: Patch coverage is 88.88889% with 5 lines in your changes missing coverage. Please review.

Project coverage is 41.71%. Comparing base (d0c9695) to head (2c6d0d4).

Files with missing lines Patch % Lines
integration/testnet/network.go 60.00% 2 Missing :warning:
cmd/bootstrap/cmd/finalize.go 90.90% 1 Missing :warning:
cmd/bootstrap/dkg/dkg.go 83.33% 1 Missing :warning:
cmd/bootstrap/run/qc.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature/efm-recovery #6745 +/- ## ======================================================== + Coverage 41.70% 41.71% +0.01% ======================================================== Files 2030 2030 Lines 180462 180459 -3 ======================================================== + Hits 75261 75285 +24 + Misses 99003 98981 -22 + Partials 6198 6193 -5 ``` | [Flag](https://app.codecov.io/gh/onflow/flow-go/pull/6745/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/onflow/flow-go/pull/6745/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow) | `41.71% <88.88%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=onflow#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features: