ongweijie7 / pe

0 stars 0 forks source link

Lacking extension for unmark attendance #21

Open ongweijie7 opened 1 year ago

ongweijie7 commented 1 year ago

Screenshot 2023-04-14 at 3.38.48 PM.png

Does not include the situation when the attendance is already unmarked.

soc-pe-bot commented 1 year ago

Team's Response

image.png

This issue is covered in the User Guide.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Screenshot 2023-04-18 at 1.19.17 PM.png

I believe including such an implementation would be important, especially if I was a developer that is looking to maintain and evolve you code, I would need to understand how you went about designing the interaction between users and the system as mentioned in the screenshot picture above.

Moreover, there is a lack of consistency between your use cases for mark and unmark. Since both of them should behave in a similar manner when an attendance is mark/unmark already and the extension is available formark 's use case(as seen below), why not include this extension in unmark to be clearer and consistent? I believe this will be confusing for a developer who sees the inconsistency after reading both the developer guide and user guide, hence it is a valid bug.

Screenshot 2023-04-18 at 1.21.19 PM.png