onivim / oni

Oni: Modern Modal Editing - powered by Neovim
https://www.onivim.io
MIT License
11.35k stars 301 forks source link

Oni does not correctly locate executables #2251

Open jordan-arenstein opened 6 years ago

jordan-arenstein commented 6 years ago

Oni Version: 0.3.4 Neovim Version (Linux only): Operating System: macOS 10.13.4

Describe your issue

The vim command :executable in oni does not match neovim's behaviour when using LaTeX commands latexmk and bibtex, in '/Library/TeX/texbin/'

Expected behaviour

Using neovim, executable('latexmk') returns 1

Actual behaviour

In Oni, executable('latexmk') returns 0. This breaks the package lervag/vimtex

Steps to reproduce

In Oni, type :echo executable('latexmk')

oni-bot[bot] commented 6 years ago

Hello and welcome to the Oni repository! Thanks for opening your first issue here. To help us out, please make sure to include as much detail as possible - including screenshots and logs, if possible.

jordan-arenstein commented 6 years ago

I have restored functionality by running ln -s /Library/TeX/texbin/latexmk /usr/local/bin and ln -s /Library/TeX/texbin/bibtex /usr/local/bin. Seems to be an issue with Oni's $PATH variable.

Although I wouldn't consider that fixed.

akinsho commented 6 years ago

@jordan-arenstein if you run :echo $PATH in terminal nvim vs. in Oni (keep in mind that oni's path isn't quite the same) do you find that the Library dir is in your $PATH, as I know we add /usr/local/bin to the path oni uses but not the Library?

jordan-arenstein commented 6 years ago

A few directories differ from the nvim and oni $PATHs, including the Library paths.

nvim $PATH: /Library/Frameworks/Python.framework/Versions/3.5/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/opt/X11/bin

oni $PATH: usr/bin:/usr/sbin/sbin:/usr/bin:/usr/local/bin