search

online-bridge-hackathon / DDS

An api that returns DDS results for a given deal or partial deal
https://bit.ly/bridge-hackathon
Apache License 2.0
4 stars 7 forks source link

Fixed camelcase and imports #27

Closed angshenting closed 4 years ago

angshenting commented 4 years ago

Fixed some of the pylint issues as mentioned in issue18

tameware commented 4 years ago

Looking better! pylint still has a few complaints. At least the ones on lines 36 and 39 should be addressed in this pull:

src/dds.py:36:0: C0103: Class name "DDtable_deal" doesn't conform to PascalCase naming style (invalid-name) src/dds.py:62:4: W0231: init method from base class 'Exception' is not called (super-init-not-called) src/dds.py:87:4: R0913: Too many arguments (9/5) (too-many-arguments) src/dds.py:87:4: R0914: Too many local variables (19/15) (too-many-locals) src/dds.py:99:8: C0103: Variable name "dl" doesn't conform to snake_case naming style (invalid-name) src/dds.py:7:4: C0412: Imports from package ctypes are not grouped (ungrouped-imports)