search

online-bridge-hackathon / DDS

An api that returns DDS results for a given deal or partial deal
https://bit.ly/bridge-hackathon
Apache License 2.0
4 stars 6 forks source link

Remove or increase thread limit #73

Closed tameware closed 4 years ago

tameware commented 4 years ago

Find out why it's there in the first place.

suokko commented 4 years ago

Do you mean libdds thread limit?

It is limiting number of thread private persistent cache for double dummy solver. The thread private data is large so it shouldn't be more than physical cores available. I can be configured with server.yaml. Default is to let libdds detect cores available.

tameware commented 4 years ago

Yes, the libdds thread limit.

I noticed in testing on my Mac that the analysis finishes substantially more quickly if I let the library set the number of threads. I do not know why our wrapper code sets a maximum of 2 by default. I'd like to know before changing it.

suokko commented 4 years ago

As of yesterday, the default is to let library use the automatic detection. Configuration can lower the limit if there is a need. (Same for memory use)

tameware commented 4 years ago

Great - thanks! Closing this issue…