search

onnx / onnx-tensorflow

Tensorflow Backend for ONNX
Other
1.27k stars 296 forks source link

Missing py2, 3 compatibility imports in CLI interfaces #324

Open tjingrant opened 5 years ago

tjingrant commented 5 years ago

@fumihwh we are missing py2, 3 compatibility related imports in cli related files.

e.g. https://github.com/onnx/onnx-tensorflow/blob/master/onnx_tf/converter.py

There's no

from __future__ import absolute_import
from __future__ import division
from __future__ import print_function
from __future__ import unicode_literals

Is this intentional? maybe we should update them.

fumihwh commented 5 years ago

I am not sure if there is no problem when calling cli in both python 2 and 3 environments, do we still need to add __future__?