search

onyx-platform / onyx-datomic

Onyx plugin for Datomic
http://www.onyxplatform.org/
Eclipse Public License 1.0
37 stars 14 forks source link

Restartable errors #35

Closed djjolicoeur closed 5 years ago

djjolicoeur commented 5 years ago

We have an application still running on 0.9.x and our transactor occasionally fails over. As is, this kills the job if we are in the middle of a tx. I forked the existing PR that handles a similar situation, however it would not handle the exception thrown in the case of a transactor failing over. In addition, datomic allows you to specify a transaction timeout via a property, i.e. -Ddatomic.txTimeoutMsec=15000, which throws an exception we can catch and handle in the plugin, but doesn't hard code the value in the plugin itself.

We have started moving our existing jobs to 0.14 and I would like to do something similar in that version of the plugin, as well.

lbradstreet commented 5 years ago

I'll merge this into 0.9.x, though 0.9.x is not supported any more. We should get a similar PR into master when you're ready.

Cheers

djjolicoeur commented 5 years ago

@lbradstreet, we are actually in the process of moving everything to 0.14, but we have some custom plugin work to do before we get there. I imagine I will be bugging you about the 0.14 version of this in the near future!

Are you going to cut a release without the -SNAPSHOT, or should I push a release clojars under a different org name and pull it in that way? i.e. `com.icxmedia/onyx-datomic "0.9.12.2". I haven't tried just cutting a release as-is sans SNAPSHOT, but I assume that will not work and wouldn't want to do it without checking.

Thanks for onyx and the many times you have helped me out! Dan J

lbradstreet commented 5 years ago

Looks like our release process doesn't automatically deploy for the 0.9.x branch since it's a bit outside of our normal release process. I've manually released 0.9.15.1.

On Wed, 13 Mar 2019 at 13:06, Daniel Jolicoeur notifications@github.com wrote:

@lbradstreet https://github.com/lbradstreet, we are actually in the process of moving everything to 0.14, but we have some custom plugin work to do before we get there. I imagine I will be bugging you about the 0.14 version of this in the near future!

Are you going to cut a release without the -SNAPSHOT, or should I push a release clojars under a different org name and pull it in that way? i.e. `com.icxmedia/onyx-datomic "0.9.12.2". I haven't tried just cutting a release as-is sans SNAPSHOT, but I assume that will not work and wouldn't want to do it without checking.

Thanks for onyx and the many times you have helped me out! Dan J

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/onyx-platform/onyx-datomic/pull/35#issuecomment-472584363, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPZHWU5qc0qciehY1Yc3RjJCop_poLUks5vWVovgaJpZM4bsVOa .

lbradstreet commented 5 years ago

Sorry, I meant 0.9.15.2.

On Wed, 13 Mar 2019 at 22:16, Lucas Bradstreet lucasbradstreet@gmail.com wrote:

Looks like our release process doesn't automatically deploy for the 0.9.x branch since it's a bit outside of our normal release process. I've manually released 0.9.15.1.

On Wed, 13 Mar 2019 at 13:06, Daniel Jolicoeur notifications@github.com wrote:

@lbradstreet https://github.com/lbradstreet, we are actually in the process of moving everything to 0.14, but we have some custom plugin work to do before we get there. I imagine I will be bugging you about the 0.14 version of this in the near future!

Are you going to cut a release without the -SNAPSHOT, or should I push a release clojars under a different org name and pull it in that way? i.e. `com.icxmedia/onyx-datomic "0.9.12.2". I haven't tried just cutting a release as-is sans SNAPSHOT, but I assume that will not work and wouldn't want to do it without checking.

Thanks for onyx and the many times you have helped me out! Dan J

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/onyx-platform/onyx-datomic/pull/35#issuecomment-472584363, or mute the thread https://github.com/notifications/unsubscribe-auth/AAPZHWU5qc0qciehY1Yc3RjJCop_poLUks5vWVovgaJpZM4bsVOa .

djjolicoeur commented 5 years ago

thanks, @lbradstreet!