search

onyxbits / TextFiction

Z-Machine interpreter for Android
https://textfiction.onyxbits.de
Apache License 2.0
71 stars 28 forks source link

Fix issues #11

Closed SGLMaster closed 9 years ago

SGLMaster commented 9 years ago

I have fix two issues in this branch: First: I removed some unused imports, it won't change anything but it makes the code clearer. Second: I added a few lines in the InputFragment.java file so the keyboard will close after the user submits the command, it only works if the 'Autocollapse Keyboard' option is set.

onyxbits commented 9 years ago

Sorry, but the way it works now is the way it is intended to work: Only the "Done" button on the softkeyboard is suppose to collapse the keyboard.

Rationale: the softkeyboard is only a fallback solution in case you cannot construct a command otherwise. Those situations are rare and the player mostly doesn't want to deal with the keyboard to begin with, so autocollapsing it is the meaningful thing to do. However, there are situations (e.g. a conversation with an NPC) in which the player might want the keyboard to stay open without having to reconfigure the app,

SGLMaster commented 9 years ago

Ok now I get it.The thing is that my tablet's keyboard doesn't have a "Done" button that's why I did the modification. Thanks anyway. And if you need any help, i can help you. I really like this app and I really programming.