search

ooni / backend

Everything related to OONI backend infrastructure: ooni/api, ooni/pipeline, ooni/sysadmin, collector, bouncers and test-helpers
BSD 3-Clause "New" or "Revised" License
51 stars 29 forks source link

Backend returns inconsistent values #893

Open jbonisteel opened 3 weeks ago

jbonisteel commented 3 weeks ago

From Slack: https://openobservatory.slack.com/archives/GKGRFHXT7/p1730227093226719

**_intl which is usually an empty object, can be null some times. https://run.ooni.org/api/v2/oonirun/links/10030 || values set to null https://run.ooni.org/api/v2/oonirun/links/10028 || values set as empty objects. We should maybe always return the empty objects.

hellais commented 1 day ago

We explicitly support None as a valid type of _intl: https://github.com/ooni/backend/blob/master/ooniapi/services/oonirun/src/oonirun/routers/v2.py#L96.

Changing this to be only an empty object would be a non-trivial amount of work as we would have to migrate all the existing OONI Run links to the new format and probably change the DB schema. Is this currently breaking clients?