oopt-goldstone / goldstone-mgmt

TIP Goldstone management layer implementation
Apache License 2.0
7 stars 9 forks source link

Introduce `south-netlink` #53

Closed ishidawataru closed 2 years ago

ishidawataru commented 2 years ago

This PR introduces south-netlink which takes over goldstone-mgmt-interfaces.yang handling from south-system. The goldstone-mgmt-interfaces.yang is also overhauled to match with goldstone-interfaces.yang.

With this change, south-netlink can support both goldstone-mgmt-interfaces.yang and goldstone-interfaces.yang seemlessly.

On the platforms where south-sonic or south-gearbox is used (those daemon handles goldstone-interfaces.yang), south-netlink will handle goldstone-mgmt-interfaces.yang to support management interface configuration.

However, in a virtual environment ( e.g., normal Linux server ) or on DentOS, south-netlink can be used to handle goldstone-interfaces.yang.

CLI code is also updated by this commit. Because the internal structure of goldstone-interfaces.yang and goldstone-mgmt-interfaces.yang became identical, we could reuse the objects for the interface command for the management-interface command.

ksandeep-palc commented 1 year ago

Hi @ishidawataru I am unable to find the south-netlink yaml file in goldstone-buildimage, so how exactly south-netlink pod is instantiated or is it run only for specific platforms ?

ishidawataru commented 1 year ago

@ksandeep-palc The module is not integrated into the goldstone-buildimage yet. Do you have any use case for it?

ksandeep-palc commented 1 year ago

Thanks @ishidawataru for the response. As management interface IP configuration is moved to south-netlink, in the absence of south-netlink pod, support for mgmt interface IP addr config is not there anymore.

ishidawataru commented 1 year ago

@ksandeep-palc Yes, you're right. Operators must use the Linux commands to configure the mgmt interfaces at this moment. south-netlink lacks many features frequently used by operators (e.g. DHCP configuration). Once south-netlink has a decent number of features, we can enable it within Goldstone.