open-contracting-extensions / european-union

OCDS for the European Union
http://standard.open-contracting.org/profiles/eu/latest/en/
Apache License 2.0
9 stars 0 forks source link

Extension for essential assets (T02) #60

Closed ColinMaudry closed 4 years ago

ColinMaudry commented 4 years ago
jpmckinney commented 4 years ago

Although significance and predominance are phrased as numbers on the forms, in the XSD/XML they are paragraphs of text.

For .assets, there's no guarantee that each paragraph will be a separate item. It might be safer to map as a simple .description string field.

ColinMaudry commented 4 years ago

:+1: for .assets to .description.

Can't we instruct implementers to cast the predominance and significance strings as a numbers?

jpmckinney commented 4 years ago

The problem is that since the XSD has no constraints on the string; it can really be anything, like "The predominance is expected to be fifty percent."

ColinMaudry commented 4 years ago

I see, that problem is everywhere in this mapping. OK for a text field, I'll update the mapping.

jpmckinney commented 4 years ago

I think I already updated it when merging the PR :) I don't remember if there were any other cases.

ColinMaudry commented 4 years ago

List of assets as .description :ok: and removed the requirement of casting value as number :ok: (https://github.com/open-contracting/european-union-support/pull/31/files#diff-20225b227b26d1457a3bbead00afa489R59)