Closed ColinMaudry closed 4 years ago
Although significance and predominance are phrased as numbers on the forms, in the XSD/XML they are paragraphs of text.
For .assets
, there's no guarantee that each paragraph will be a separate item. It might be safer to map as a simple .description
string field.
:+1: for .assets
to .description
.
Can't we instruct implementers to cast the predominance and significance strings as a numbers?
The problem is that since the XSD has no constraints on the string; it can really be anything, like "The predominance is expected to be fifty percent."
I see, that problem is everywhere in this mapping. OK for a text field, I'll update the mapping.
I think I already updated it when merging the PR :) I don't remember if there were any other cases.
List of assets as .description
:ok: and removed the requirement of casting value as number :ok: (https://github.com/open-contracting/european-union-support/pull/31/files#diff-20225b227b26d1457a3bbead00afa489R59)
tender.hasEssentialAssets
(boolean)tender.essentialAssets.significance
(number)tender.essentialAssets.predominant
(number)tender.essentialAssets.assets
(list of strings)