search

open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)
http://standard.open-contracting.org/
Other
139 stars 46 forks source link

Add planning final status fields and codelist #1642

Closed duncandewhurst closed 6 months ago

duncandewhurst commented 1 year ago
duncandewhurst commented 1 year ago

The spell-check failure is addressed by https://github.com/open-contracting/standard/pull/1641

duncandewhurst commented 1 year ago

Ah, good spot. I shouldn't have marked #1582 as being closed by this PR. I figure it makes sense to do those other final status date fields when adding the new final status fields in #1160.

Alternatively, we could do all of the final status and final status date fields in this PR. @jpmckinney let me know what you prefer.

jpmckinney commented 1 year ago

My comment in #1583 was to close it "After https://github.com/open-contracting/standard/issues/1160 and https://github.com/open-contracting/standard/issues/1582". #1583 is more like a new feature, whereas #1160 is a major change (#1582 is also more like a new feature). The major change should lead, before related features are implemented.

I prefer to close #1160 on its own. #1582 and #1583 could potentially be combined.

duncandewhurst commented 1 year ago

Sounds good! I'll pause work on this PR and prepare a PR for #1160 (PR: https://github.com/open-contracting/standard/pull/1648)

jpmckinney commented 8 months ago

@duncandewhurst This is now unblocked.

duncandewhurst commented 8 months ago

I think this is ready for review, unless I missed something.