search

open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)
http://standard.open-contracting.org/
Other
139 stars 46 forks source link

remove mention of building blocks and blocks from documentation #1660

Open odscjen opened 1 year ago

odscjen commented 1 year ago

closes #1347

Used primarily "objects" as per the section of the style guide that states

When describing JSON schema * “object”, not “block”

but did use "sub-schema" in a few instances.

There's 2 uses of "block" in the schema itself but they'll be covered by a PR for https://github.com/open-contracting/standard/issues/850

jpmckinney commented 12 months ago

There are two occurrences in documentType.csv (subContract, billOfQuantity) where we can just delete the last clause. If those aren't handled by other PRs or issues, let's fix them here.

Noting that use of "block" on two occasions in the Milestone sub-schema will be fixed by #850

odscjen commented 12 months ago

I've removed the final sentences from both of those codes in documentType as I don't they were being picked up anywhere else

odscjen commented 11 months ago

added an issue to the handbook repo to update the style guide https://github.com/open-contracting/standard-development-handbook/issues/285

odscjen commented 10 months ago

@jpmckinney are you ok with the suggestions in https://github.com/open-contracting/standard-development-handbook/issues/285#issuecomment-1863261476, if so I'll redo this PR with those all in mind