Make examples minimal - Githubissues

open-contracting / standard

Documentation of the Open Contracting Data Standard (OCDS)

http://standard.open-contracting.org/

Other

139 stars 46 forks source link

Make examples minimal #1680

Open duncandewhurst opened 9 months ago

duncandewhurst commented 9 months ago

closes #1449

Closes #1666

Replaces https://github.com/open-contracting/standard/pull/1678

Implements proposed improvements from https://github.com/open-contracting/standard/issues/1449#issuecomment-1849353843

[x] Replace 1666-make-examples-minimal with 1.2-dev in handbook

jpmckinney commented 8 months ago

FYI, I'm resolving conflicts.

jpmckinney commented 8 months ago

When resolving conflicts, I think my only not-purely-related-to-conflicts changes were:

editing the new unsuccessful_tender/tenderUpdate.json to use finalStatus (and lowercase 'unsuccessful`)
changing a line in framework_agreements.md about status being 'active' to finalStatus not being set
using periods consistently in lists in framework_agreements.md

jpmckinney commented 8 months ago

Other changes while resolving conflicts again:

linked_releases.json: Added 'tenderAmendment' release back, to parallel tender.json (even though less minimal).
records_reference.md: Updated to mention 3rd release id
amendments.md: I had to re-do changes by resolving conflicts, because the commit was squashed in #1661 but is unsquashed in this PR

odscjen commented 7 months ago

@jpmckinney fyi if helpful I'm happy to make any post-review changes that may be needed rather than waiting on @duncandewhurst to return, #1681 and #1685 are both blocked until this PR is merged

jpmckinney commented 6 months ago

@jpmckinney fyi if helpful I'm happy to make any post-review changes that may be needed rather than waiting on duncandewhurst to return, #1681 and #1685 are both blocked until this PR is merged

I was mid-review when I had to turn my attention to other tasks. I'll hopefully get it done before Duncan returns :)