open-dis / open-dis-javascript

Javascript implementation of the IEEE-1278.1 Distributed Interactive Simulation (DIS) application protocol v6 and v7
BSD 2-Clause "Simplified" License
11 stars 12 forks source link

Change SignalPdu and IntercomPdu signal type to unsigned int #29

Closed drcampbell closed 2 months ago

drcampbell commented 2 months ago

This pull request modifies the SignalPdu and IntercomSignalPdu classes to change the signal type from signed int to unsigned int. The Chunk class is also updated to read and write unsigned bytes. It retains default behavior of signed bytes.

This change reflects how the open-dis libraries for c++, c#, and python handle signal pdus as a vector of unsigned int8s.

leif81 commented 2 months ago

Thank-you @drcampbell !