search

open-editions / corpus-joyce-portrait-TEI

The Open Scholarly Edition of James Joyce's A Portrait of the Artist as a Young Man
GNU General Public License v3.0
20 stars 20 forks source link

mark up places with geocodes #43

Closed JonathanReeve closed 7 years ago

goldieshen commented 7 years ago

I am going to mark up locations in Chapter 1, but I don't know how to geocode. Do I use an address to longitude/latitude converter online, or should I just mark place names? How should I do this task?

JonathanReeve commented 7 years ago

Great! And good question. Mapping isn't my specialty, but this is my best guess:

Before: 

And then we hung out at St. Stephen's Green

After: 

And then we hung out at <placeName><geo>41.687142 -74.870109</geo>St. Stephen's Green</placeName>
JonathanReeve commented 7 years ago

The 41.68 is the latitude and the -74.87 is the longitude (those are made up examples).

JonathanReeve commented 7 years ago

Oops, looks like I was wrong. Here's better markup: 

And then we hung out at <place><location><geo>41.687142 -74.870109</geo></location><placeName>St. Stephen's Green</placeName></place>.
goldieshen commented 7 years ago

Thank you! I’ll use that format. If I can, I’ll try to make the places Stephen thought of distinct. So when you mean for the assignment, we need to mark up 20-30 lines/words/places by the deadline, you mean 20-30 marks total from any category, right? Again, thanks!

JonathanReeve commented 7 years ago

It's 20-30 lines of text, so when you're about to submit a pull request, scroll down to the list of changes, and it should say something like "Showing 1 changed file, with 20 additions and 20 deletions." Here's a screenshot:

pr-changes

Alanburnett commented 7 years ago

I am going to mark up locations in Chapter 2.

goldieshen commented 7 years ago

I am going to mark up Ch. 3, 4, and 5.

JonathanReeve commented 7 years ago

Nice! Go for it.

On Wed, Nov 2, 2016, 16:39 goldieshen notifications@github.com wrote:

I am going to mark up Ch. 3, 4, and 5.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JonathanReeve/corpus-joyce-portrait-TEI/issues/43#issuecomment-257991673, or mute the thread https://github.com/notifications/unsubscribe-auth/ABwh3DKs9HKuFU3nNWnmCOCQQdjLgUD_ks5q6PTkgaJpZM4J_OG8 .

JonathanReeve commented 7 years ago

I'm very happy to be closing this issue as complete, after merging in the lastest PR!