search

open-editions / corpus-joyce-ulysses-tei

James Joyce's novel Ulysses in TEI XML. Work-in-progress.
20 stars 17 forks source link

Fix the problematic line(s) breaking Travis. #43

Closed charlesreid1 closed 7 years ago

charlesreid1 commented 7 years ago

Hmm... maybe not.

charlesreid1 commented 7 years ago

Woo hoo! Travis is now passing. This PR is OK to review for a merge.

This revises all of the tags just added to Ithaca (17). Previously, I was using <place type="city"><placeName>Dublin</placeName></place>, but according to the <place> spec on TEI, specifically the "contained by" section, the <place> tag cannot appear between <p></p> tags. (You'd think they'd mention that somewhere...?)

This PR replaces all of the <place> tags with just a <placeName> tag, so that

<place type="city"><placeName>Dublin</placeName></place>

becomes

<placeName type="city">Dublin</placeName>

If we need to add <location> data, they can go inside the <placeName> tag (see <placeName> TEI spec, the "may contain" section.)

JonathanReeve commented 7 years ago

Looks great, thanks! Love to see those green checkmarks.