Closed Magynon closed 1 year ago
Hi @Magynon Please squash your commits into a single commit.
One final thing you need to do is to add the Signed-off-by: Your Name <your@email.com>
. To do so, use the following command: git commit --amend -s
. The -s
argument will add the signature for you. Then, git push -f
to update the remote repo.
Thanks guys for the guidance!
You're welcome, but the error says it's not done yet [1]. Configure your name using git config --global user.name "Stefan Magirescu"
. Your name was set to your GitHub username, not to your real name.
Should be fine now. Guess I won't be adding "git enthusiast" to my resume too soon 🤣
Still not there, it seems :laughing:. You need to do the same thing for the email address: git config --global user.email stefanmagirescu@yahoo.com
: https://github.com/open-education-hub/operating-systems/actions/runs/4900382608/jobs/8751059425?pr=301.
I changed the email config accordingly, but as you can see, things are still not ok... should I maybe remove the signature and sign it again?
Edit: I amended the latest commit. Maybe it will work now.
Yes, that did it. Good work, @Magynon!
Updated the DIE() macro with the missing matched open parentheses.