search

open-eid / DigiDoc4-Client

DigiDoc4 is an application for digitally signing and encrypting documents; the software includes functionality to manage Estonian ID-card - change pin codes etc.
https://www.id.ee/en/article/install-id-software/
Other
120 stars 42 forks source link

Feature request: Add flatpak support to Digidoc #1299

Open Gren-95 opened 1 month ago

Gren-95 commented 1 month ago

Hello,

Is it possible to build flatpak version of digidoc to simplify the installation on most Linux distros?

It would be simpler for the end user to just install it from flathub instead of building it from source.

Gren-95 commented 1 month ago

I have recently found this project, but i would like to see it be incorporated in the main project if possible.

https://github.com/flathub/ee.ria.qdigidoc4

ls-1N commented 2 weeks ago

I agree - an official Flathub release would be more convenient, secure, and accessible. The RIA homepage can simply provide a Flathub link/button - more people are used to Google Play or Apple App Store links/buttons on websites instead of Windows .exe files directly on-site like in the olden days.

The advantage of an official Flathub release is that even though the community release is open-source, most users won't have the tech literacy to find out where their Linux app store (that has a Flathub integration) got the Digidoc4 app from. The same goes for actually understanding all the commits in a reasonable amount of time even for tech-savvier users.

So people will do the most convenient thing (use the app store) and not care about security if it is ambiguous and takes several extra steps. The extra maintenance overhead of a Flathub app is very low, I believe.

ls-1N commented 2 weeks ago

@Gren-95 In theory, #793 already has a discussion about packaging, including Snap, Appimage, and Flatpak.

metsma commented 2 weeks ago

There is one main fundamental problem with these universal packaging formats. PCSCLite does not guarantee a stable API for smart card communication. At least three different versions are needed, and users must understand which OS supports which version (see PCSCLite issue, qdigidoc commit).

Other related issues:

Until these are resolved, I don't see them as viable mainline distribution methods. This is my personal opinion.

ls-1N commented 2 weeks ago

There is one main fundamental problem with these universal packaging formats. PCSCLite does not guarantee a stable API for smart card communication. At least three different versions are needed, and users must understand which OS supports which version (see PCSCLite issue, qdigidoc commit).

Other related issues:

* MIME type registration (e.g., [Flatpak issue](https://github.com/minosimo/qdigidoc-flatpak/issues/21)).

* AppImage lacks usable signing support for end users.

* Some OSes require additional installation steps.

Until these are resolved, I don't see them as viable mainline distribution methods. This is my personal opinion.

Maybe you and I should add our opinions/takes on #793 as well and this particular issue should be closed since #793 has expanded in scope to also discuss Snap and Flatpak. Your counterpoint would calm some of the pings for updates there. As it is now, issue #793 gives the impression of being forgotten without any counterpoints or complexities. Ideally, the title on #793 should also be changed since some users read only the titles (not the whole issue discussion) to decide whether they should open a new issue (this one), thus this might happen again.