search

open-ephys / bonsai-onix1

Bonsai library for the Open Ephys Onix Acquisition System
https://open-ephys.github.io/onix1-bonsai-docs
MIT License
4 stars 3 forks source link

StreamReader arguments in NeuropixelsV1Helper.ParseAdcCalibrationFile() and ParseGainCalibrationFile() should be a path #283

Open jonnew opened 1 month ago

jonnew commented 1 month ago

The file input argument in the following functions:

https://github.com/open-ephys/onix-bonsai-onix1/blob/3fdcec67f5f5d548ddf9125d7859565b55a48d08/OpenEphys.Onix1/NeuropixelsV1Helper.cs#L21

https://github.com/open-ephys/onix-bonsai-onix1/blob/3fdcec67f5f5d548ddf9125d7859565b55a48d08/OpenEphys.Onix1/NeuropixelsV1Helper.cs#L65

should either be a FileStream or a string indicating a path. StreamReader is to general because calibration data is always provided in a file and this function call expects to start from the beginning of the stream. This will require a change in the public API.

bparks13 commented 4 weeks ago

These methods have been marked as [Obsolete] in #291, but will not be modified/removed until 1.0.0.