open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
569 stars 67 forks source link

fix: fraction operation - add validations for nil values (#1285) #1294

Closed Baalekshan closed 7 months ago

Baalekshan commented 7 months ago

This PR

adds validation for nil values by using []interfaces{} instead of []any

Related Issues

Fixes #1285

Notes

Follow-up Tasks

How to test

netlify[bot] commented 7 months ago

Deploy Preview for polite-licorice-3db33c canceled.

Name Link
Latest commit 784fd4b03f3ccc9d9c6f4aacff16eac68b4104be
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/662290f5f8dfee00087ad9a4
Kavindu-Dodan commented 7 months ago

@Baalekshan thank you for your interest in this issue.

I had to fix this as we were preparing the next release of flagd [1]. You can check the fix I did here [2]. I hope you find it helpful and continue to contribute in future :)

[1] - https://github.com/open-feature/flagd/pull/1292 [2] - https://github.com/open-feature/flagd/pull/1295

Baalekshan commented 7 months ago

@Kavindu-Dodan Yeah I will look for contributing in future.