open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
569 stars 67 forks source link

feat: Support blob type sources and GCS as an example of such source. #1366

Closed alan-kut closed 4 months ago

alan-kut commented 4 months ago

This PR

Notes

In a similar fashion other cloud storages supported by go-cloud blob can be added.

How to test

netlify[bot] commented 4 months ago

Deploy Preview for polite-licorice-3db33c ready!

Name Link
Latest commit 7d2f912c4f439dc4dbd88926ccf553e6c63ea0a3
Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/66a90cb1b0ff8a0008cfe27b
Deploy Preview https://deploy-preview-1366--polite-licorice-3db33c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

beeme1mr commented 4 months ago

Hey @alan-kut, thanks for the PR. I'll test this out E2E tomorrow.

alan-kut commented 4 months ago

Thanks. I fixed lint error and data race.

Few assumptions I made in this code:

alan-kut commented 4 months ago

I changed the log to debug, signed off commit, updated the docs (in a new commit).

Should I squash the commits somehow? Rebase them on main?

beeme1mr commented 4 months ago

I've reviewed all the licensing issues detected by FOSSA. The library is licensed BSD-3, but comments in the code referred to other licenses, which triggered a false positive.

toddbaert commented 4 months ago

I changed the log to debug, signed off commit, updated the docs (in a new commit).

Should I squash the commits somehow? Rebase them on main?

Commits are squashed automatically, everything will be clean in main.