open-feature / flagd

A feature flag daemon with a Unix philosophy
https://openfeature.dev
Apache License 2.0
569 stars 67 forks source link

[DOC] Monitoring metrics are misnamed #1371

Closed agardnerIT closed 3 months ago

agardnerIT commented 4 months ago

Change in the documentation

This page shows:

flagd expose following metrics,

http.server.duration
http.server.response.size
http.server.active_requests
feature_flag.flagd.impression
feature_flag.flagd.evaluation.reason

1) Typo: expose should be exposes 2) The metrics are misnamed:

beeme1mr commented 3 months ago

Hey @agardnerIT, I've fixed the typos. The documented metric names are correct and follow OTel's recommended naming convention. However, Prometheus, Dynatrace, and likely others have different metric naming requirements. I've added a disclaimer that the metric names may be transformed by the consuming monitoring tool.