search

open-iscsi / targetd

Remote configuration of a LIO-based storage appliance
GNU General Public License v3.0
71 stars 28 forks source link

Add support for block volumes resizing #81

Closed johanfleury closed 3 years ago

johanfleury commented 3 years ago

Implements #80

johanfleury commented 3 years ago

Ok, so I’ve tried to keep the same behavior as in vol_copy. I did not test the changes on a production environment but that should be good.

I’m not sure what _ep_ and _gp_ means in test names, so they might be wrongly named.

Let me know if there’s anything wrong.

tasleson commented 3 years ago

Ok, so I’ve tried to keep the same behavior as in vol_copy. I did not test the changes on a production environment but that should be good.

I’m not sure what _ep_ and _gp_ means in test names, so they might be wrongly named.

_ep_ == error path _gp_ == good path

This allows an easy way to run one or the other with a unit test filter. I need to add a blurb on that, sorry.

I'll review your PR tomorrow. I'll also see if @dsonck92 would like to review it too!

Thanks!

tasleson commented 3 years ago

@johanfleury Thank you!

johanfleury commented 3 years ago

@dsonck92 at first I wanted to work with https://github.com/kubernetes-retired/external-storage/tree/master/iscsi/targetd, but I’m really not a big fan of Go, so I went ahead and made something in Python with kopf.

If you want to take a look, the code is on GitLab (there’s a read-only mirror here on GitHub).

While testing targetd and writing the provisioner, I also wrote a small CLI tool and I ended up creating a (really simple) client library: targetd-client (read-only mirror on GitHub).

Feel free to open issues/MR if you feel the need. If you want to contact me, I’m Arcaik on Freenode, Geeknode and OFTC if you use IRC, otherwise my email address is on my profile.