search

open-learning-exchange / planet

🌍 Planet Learning - Angular application
https://hub.docker.com/r/treehouses/planet
GNU Affero General Public License v3.0
62 stars 39 forks source link

challenges: notifications system #7723

Closed RheuX closed 3 weeks ago

RheuX commented 3 weeks ago

image

Right now, notifications will show everytime that dialog challenge comes up (#7714 - should work with this, if this only pops up once).

The only thing that isn't working right now is the notification from the page (I think the router and click event handler is messing with each other. But the dropdown should be working for now. Ill try to fix the notifications also

Both notifications should be working right now, the only part I would like to fix is making it more neat. I had to import the dialogNotifications, and functions in 2 different places, wondering if i could make it more tidier

RheuX commented 3 weeks ago

Oh, when the challenges is finished, it should stop sending notifications (if it does prompt it), i didn't check for that edge case, unless a PR has taken care that if a challenge is finished, it wouldn't prompt the challenges again

RheuX commented 3 weeks ago

Cool thanks for the review, ill change some of them later!

RheuX commented 3 weeks ago

I will close down this PR, it will be finished by #7746