search

open-learning-exchange / planet

🌍 Planet Learning - Angular application
https://hub.docker.com/r/treehouses/planet
GNU Affero General Public License v3.0
62 stars 39 forks source link

challenges: notification system changes #7746

Closed RheuX closed 3 weeks ago

RheuX commented 3 weeks ago

Notification now works for the challenges,

Notes:

only edge case is that the status only first initalized when youre in the community post. If you refresh anywhere and you never got the dialog challenged open from community, if you open it from the notification, it would say you didn't do any of them.

  • need to confirm if this is fix in the merging (meaning, just refresh at any point, and open the dialog from the notification. -> if you see the status check, that means its fixed)

P.S. If you dont understand the edge case, then let me know, so i can clarify it

RheuX commented 3 weeks ago

i personally cannot test it out, since the code is in the included planets (like in guatamale, san pablo, etc). I think the code for checking the status is being check twice or thrice, so even if i brute force it then it wouldn't work, but if there is some issues, please let me know, so i can probably check it out myself

jessewashburn commented 3 weeks ago

The notification system plays nicer with my popup code. It no longer duplicates notifications when navigating to the community page - only when there's a new popup upon login.

Some problems (Not necessarily related to this PR. Feel free to create separate issues or I can do so on Monday):

the notification number only updates on refresh.
image

My progress is not updating.

image

image

I'm allowed to join multiple times, because the Unirse button doesn't go away..

image

RheuX commented 3 weeks ago

@jessewashburn could you have a video on how you do that (i meant the progress not updating, is it just from the community post to begin with)? sorry, for the inconvenience.

and the notification thing, mutugi said he would look into it because im not sure if its supposed to be responsive or not (some notifications require you to refresh first), and i cannot test out if thats the case because most of the notification I ever receive is sending to another user (unless i run in 2 different ports, but probably should wait for mutugi)

RheuX commented 3 weeks ago

@jessewashburn could you have a video on how you do that (i meant the progress not updating, is it just from the community post to begin with)? sorry, for the inconvenience.

also, if you could, let me know which planet did you tested on, since it only works in some planets (not our planet)

Thanks again!!

Mutugiii commented 3 weeks ago

Merging with #7741