search

open-lms-open-source / moodle-plugin-ci

Assist with running a Moodle plugin in Travis CI
https://blackboard-open-source.github.io/moodle-plugin-ci/
GNU General Public License v3.0
42 stars 37 forks source link

mustache linter / vnu & java versions / warnings & checks #108

Open stronk7 opened 4 years ago

stronk7 commented 4 years ago

Somehow related with #91 ...

it seems that current local_ci vnu version installed (18.11.5) has some problems with java11, more exactly it emits the following warning that breaks output Warning: Nashorn engine is planned to be removed from a future JDK release.

So, right now, we are trying to reproduce that with local_ci (adding 1 specific assertion to check if the warning is emitted):

https://travis-ci.org/stronk7/moodle-local_ci/builds/625923516

And, also, we are trying with the same assertion plus vnu updated to (19.9.4) to see if that avoids the warning:

https://travis-ci.org/stronk7/moodle-local_ci/builds/625921197

Apart from the results there (they are running right now), what has surprised us is that check within moodle-plugin-ci:

https://github.com/blackboard-open-source/moodle-plugin-ci/blob/master/src/Command/MustacheCommand.php#L118-L120

Apparently... it's looking for way older versions, so not sure how current (or future) ones can work at all.

So, just creating this to comment about the vnu/java problems, how we are looking forward fixing them in local_ci (note that there is also a -Dnashorn.args="--no-deprecation-warning" switch to avoid it... but better if we can get a fully working version... so trying that first. And, specially about the apparent outdated check.

Ciao :-)

stronk7 commented 4 years ago

Aha, so the 2 travis runs above (vnu 18 and 19) passed ok, hence they are not subject to the Nashorn warning. Cool!

Still moodle-plugin-ci seems to require older (exposed to the 'Nashorn warning`) version 17.

Uhm...